Conversation
syl-oh
left a comment
There was a problem hiding this comment.
Nice, that'll make remembering all the debug flags easier
There was a problem hiding this comment.
Do we want to use that in the CI for some test to avoid regression?
|
@T4rk1n What do you think about using
|
|
@T4rk1n For the flags, is there a way to make the helptext clearer to the user about which option is the default? I.e. if I can pass For that matter (since I do know that no-debug is the default), what is the use case for the |
|
We should be able to detect the app object automatically given a Python file. Here's a pattern to do this: https://github.com/plotly/de-client/blob/main/src/de_client/cli/root.py#L302-L306 |
Yes that might be more convenient 👍
Oh, the |
| :param app_path: The import path to the Dash app instance. | ||
| :return: The loaded Dash app instance. | ||
| """ | ||
| app_split = app_path.split(":") |
There was a problem hiding this comment.
check that len(app_split) == 2 here?
There was a problem hiding this comment.
OK, I see that further down you're allowing users to provide just the module name, then using the first Dash you find in that module.
| app_instance = module_var | ||
| break | ||
|
|
||
| if not isinstance(app_instance, Dash): |
There was a problem hiding this comment.
if I run with just the module name, but the module doesn't define a Dash, I think app_instance will be uninitialized at the point of the isinstance() check.
|
FYI @LiamConnors , the basic |
|
@T4rk1n is this still relevant? |
Add a command to run dash app from the terminal.
The command can be run two methods:
plotly run app:app --debugpython -m dash run app:app --debugThe arguments follow
Dash.run, run help: